[Concurrency] DiscardingTaskGroup (rev 3) #62914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip on options implement discardResults as a flag passed to grout init
ktoso
added
swift evolution pending discussion
ktoso
changed the title
ktoso
changed the title
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
Seems CI now automatically assigns reviewers? |
|
@swift-ci please smoke test |
|
Seems like a minor real issue remains, but we're almost done :) |
ktoso
commented
Jan 9, 2023
ktoso
commented
Jan 9, 2023
karwa
reviewed
Jan 9, 2023
karwa
reviewed
Jan 9, 2023
DougGregor
approved these changes
Jan 10, 2023
stdlib/public/BackDeployConcurrency/CompatibilityOverrideConcurrency.def
Outdated
Show resolved
Hide resolved
ktoso
force-pushed
the
wip-task-group-twotypes
branch
from
c9297b4 to
6d63cf4
Compare
ktoso
force-pushed
the
wip-task-group-twotypes
branch
from
54ff0a5 to
128e2b2
Compare
|
@swift-ci please smoke test |
This reverts commit 128e2b2.
ktoso
added
swift evolution approved
|
Meh, stray import Darwin in test broke the windows CI -- landing this now :) |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner implementation than previously attempted, in that it shares implementation bits with the
TaskGroup, which is now calledAccumulatingTaskGroupinternally. We're able to re-use the common things and make the things a discarding group cannot do, not available at all, rather than awkwardly if-around-everything as the previous implementation attempt did (and without copying ALL of the implementation as the previous previous implementation did).Replaces #62361
Resolves rdar://101965913