[Macros] Freestanding declaration macros #62934
Conversation
rxwei
requested review from
hborla,
xedin,
slavapestov,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro and
zoecarver
as code owners
rxwei
force-pushed
the
freestanding-declaration-macros
branch
9 times, most recently
from
6105347 to
d1f28a2
Compare
|
@swift-ci please test |
rxwei
force-pushed
the
freestanding-declaration-macros
branch
from
d1f28a2 to
a5b99bf
Compare
|
@swift-ci please test linux |
|
@swift-ci please test macos |
|
@swift-ci please clean test windows |
lib/Sema/TypeCheckDeclPrimary.cpp
Outdated
| llvm_unreachable("FIXME: macro expansion decl not handled in DeclChecker"); | ||
| auto expanded = evaluateOrDefault( | ||
| Ctx.evaluator, ExpandMacroExpansionDeclRequest{MED}, {}); | ||
| // FIXME: Handle this in name lookup instead. |
There was a problem hiding this comment.
Definitely agreed that this should be handled in name lookup. This won't work across multiple source files.
| // Call-like macros need to be resolved. | ||
| else { | ||
| using namespace constraints; | ||
| ConstraintSystem cs(dc, ConstraintSystemOptions()); |
There was a problem hiding this comment.
This looks a whole lot like CSGen for MacroExpansionExpr. Can we unify the implementations?
There was a problem hiding this comment.
I think we can pull it out to TypeCheckMacros.h. I can do it in a separate patch.
| @@ -498,3 +498,165 @@ Expr *swift::expandMacroExpr( | |||
| "Type checking changed the result type?"); | |||
| return expandedExpr; | |||
| } | |||
|
|
|||
| /// Expands the given macro expansion declaration and type-check the result. | |||
| bool swift::expandFreestandingDeclarationMacro( | |||
There was a problem hiding this comment.
Hmm, lots of duplication with the expandMacro for expressions. Can we unify them somehow?
There was a problem hiding this comment.
We can definitely pull out the buffer creation, source info creation and the call to ASTGen in a follow-up patch.
rxwei
force-pushed
the
freestanding-declaration-macros
branch
from
a5b99bf to
dc9260d
Compare
|
@swift-ci please smoke test |
rxwei
force-pushed
the
freestanding-declaration-macros
branch
from
dc9260d to
a6788e8
Compare
|
@swift-ci please smoke test and merge |
Add support for freestanding declaration macros. - Parse `@declaration` attribute. - Type check and expand `MacroExpansionDecl`. Known issues: - Generic macros are not yet handled. - Expansion does not work when the parent decl context is `BraceStmt`. Need to parse freestanding declaration macro expansions in `BraceStmt` as `MacroExpansionDecl`, and add expanded decls to name lookup.
rxwei
force-pushed
the
freestanding-declaration-macros
branch
from
a6788e8 to
f17b7c4
Compare
|
@swift-ci please smoke test and merge |
|
|
||
| DeclAttribute('declaration', 'Declaration', | ||
| OnMacro, AllowMultipleAttributes, | ||
| ABIStableToAdd, ABIStableToRemove, APIStableToAdd, APIBreakingToRemove, # noqa: E501 |
There was a problem hiding this comment.
TIL what # noqa: E501 is for... Why doesn't it run on linux!?
|
Sorry for the CI breakage. I didn't know "test and merge" would bypass Windows CI. @shahmishal @compnerd |
Add support for freestanding declaration macros.
@declarationattribute.MacroExpansionDecl.Known issues:
BraceStmt. Need to parse freestanding declaration macro expansions inBraceStmtasMacroExpansionDecl, and add expanded decls to name lookup.