Fix async_extended_frame_info_watchos test #62949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimizer got smarter and stopped emitting a stack frame for the empty `someAsyncFunction`, so the test started failing. Adding an opaque function call to the function body forces the function to get set up properly, so the test starts passing again. rdar97790231
|
@swift-ci please test |
|
We may want to fix the |
To help this test run in production environments, I've reduced the requirements of the test. It used to require that the compiler was running on an armv7k or arm64_32 watchOS device, which I don't think is a test configuration that gets hit all that often. The new requirements are that you're on watchOS or the simulator, and can produce arm64_32 code. The test only verifies that the emitted asm is valid, not that it runs, so we don't need to be running on the specific hardware. Additionally, the test only checks the output of arm64_32, not of armvk7, so we only require the 64-bit arm backend. It would be better if we could check for available SDKs though. The test only requires an SDK, it doesn't need to be run on the simulator or the watch.
Adding test to verify correct behavior from swift when targeting arm64 macOS. We caught the fact that the optimizer got smarter on arm64 in the watchOS test, which doesn't seem to get run in PR testing. The updated test catches it now.
|
@swift-ci please test |
|
Linux failure: This change doesn't affect Linux, or this test, so this looks unrelated. |
|
Verified from logs; watchOS simulator testing is now running and passing |
|
@swift-ci please test Linux |
etcwilde
deleted the
ewilde/fix-async_extended_stack_frame_info_watchos_test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimizer got smarter and stopped emitting a stack frame for the empty
someAsyncFunction, so the test started failing. Adding an opaque function call to the function body forces the function to get set up properly, so the test starts passing again.Fixes rdar://97790231