Skip to content

[Interop][SwiftToCxx] Add class type support for enum with associated value #62952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

WANGJIEKE
Copy link
Contributor

This pull request adds support using class type in Swift's enum with associated value.

@hyp Can you please review this pull request? Thanks.

@hyp
Copy link
Contributor

hyp commented Jan 11, 2023

@swift-ci please test

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Jan 11, 2023
@hyp
Copy link
Contributor

hyp commented Jan 18, 2023

@swift-ci please test

@hyp
Copy link
Contributor

hyp commented Jan 18, 2023

@swift-ci please test source compatibility

Copy link
Contributor

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hyp hyp merged commit 13ff3fe into swiftlang:main Jan 19, 2023
@WANGJIEKE WANGJIEKE deleted the cxx-interop-enum-associated-value-class-type branch January 19, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants