Add the open_pack_element instruction #62955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmccall
requested review from
AnthonyLatsis,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci Please test |
rjmccall
force-pushed
the
open_pack_element
branch
from
afff637 to
73a3886
Compare
|
@swift-ci Please test |
This is needed for general fidelity in SIL, since generic argument lists are used for a lot of different things that aren't restricted from containing multiple packs. I haven't actually done the work to use Pack structure to disambiguate the resolution of pack parameters, but this is a good start. We'll probably need something like this in source eventually, so there's no reason to regret adding all the infrastructure for it.
This is generally easier for clients to work with.
IRGen not yet done.
rjmccall
force-pushed
the
open_pack_element
branch
from
73a3886 to
37baf9b
Compare
|
@swift-ci Please test |
|
Windows failure should be fixed with #62962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.