[Serialization] Recover in opaque type deserialization logic on XRef errors #62980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slavapestov Are there side-effects from dropping the underlying type of an opaque return type that I should test for? |
If the underlying type of an opaque type references an implementation-only imported type, drop the underlying type information. Without this fix, once we enable deserialization safety, we see crashes or dropped decls in more existing tests: IRGen/mangle-opaque-return-type.swift IRGen/opaque_result_type_private_underlying.swift Serialization/Recovery/implementation-only-opaque-type.swift rdar://103238451
xymus
force-pushed
the
recover-opaque-types
branch
from
263d154 to
71f116c
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the underlying type of an opaque return type references an implementation-only imported type, drop the underlying type information and keep going.
The failure is tested by the new implementation-only-opaque-type.swift test. I've also seen it in WIP deserialization safety feature where there are crashes or dropped decls in more existing tests:
rdar://103238451