Walk into top level pattern binding decls to resolve conditions #6302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge. |
|
@swift-ci please smoke test. |
|
@swift-ci please smoke test Linux platform. |
|
In this case though the PBD was inside a method. Same bug? |
|
Should be. Sounds like the pattern bindings in the body got delayed and we came around to re-parse them and evaluate the condition later which would have entered |
|
⛵️ |
|
@slavapestov Can you confirm if this gets AlamoFire building again? |
|
@CodaFi Yep it did. Thanks! Do you mind adding a changelog entry for this feature also? |
|
Absolutely, that was next on the list after squashing the nits leftover from this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a regression @slavapestov identified where Condition Resolution would fail to walk into
PatternBindingDecls in-parse-as-librarymode.