[Macros] Skeletal implementation of accessor macros #63023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation. Accessor macros are attached macros (written with attribute syntax) that can generate accessors for a property or subscript. Recognize custom attributes that are accessor macros when written on a storage declaration, and expand those macros. This is very much a work in progress, and the result of the expansion isn't yet parsed or wired into the AST.
DougGregor
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
rintaro and
zoecarver
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
Linux failure looks unrelated... |
Once an accessor macro has produced accessors, parse them and wire them into the AST so the rest of the compiler will see them. First end-to-end test case!
|
@swift-ci please smoke test |
DougGregor
changed the title
|
@swift-ci please smoke test |
|
macOS CI failures are unrelated. |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Sep 22, 2024
Re-enables the check that children of ASTScope nodes are added in source range order. This seems to have been accidentally disabled permanently in swiftlang#63023.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessor macros are attached macros (written with attribute syntax)
that can generate accessors for a property or subscript. Recognize
custom attributes that are accessor macros when written on a storage
declaration, and expand those macros to produce accessors.
This is enough to get the most basic example working, but needs a
significant amount of refactoring and a lot more error handling.