Skip to content

[AddressLowering] Project at storage. #63033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 27, 2023
Merged

[AddressLowering] Project at storage. #63033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4e6eb51
[AddressLowering] Test: Added for arg behavior.
nate-chandler Jul 24, 2023
a1d1099
[SIL] Promoted least-common ancestor to Dominance.
nate-chandler Jul 15, 2023
c9768e6
[AddressLowering] Gardening: Detypo'd.
nate-chandler Jul 13, 2023
473985f
[AddressLowering] Gardening: Detypo'd.
nate-chandler Jul 24, 2023
64ac0bd
[AddressLowering] Gardening: Removed comment.
nate-chandler Jan 6, 2023
053cc77
[AddressLowering] Gardening: Undefaulted argument.
nate-chandler Jul 13, 2023
ba6b019
[AddressLowering] NFC: Comment projection chains.
nate-chandler Jul 24, 2023
e3428ae
[AddressLowering] NFC: Add more dump functions.
nate-chandler Jan 14, 2023
d9cf437
[AddressLowering] NFC: Added const variant.
nate-chandler Jan 13, 2023
a4aef54
[AddressLowering] NFC: Add projection iterator.
nate-chandler Jan 13, 2023
a23bcef
[AddressLowering] NFC: Extracted function.
nate-chandler Jan 14, 2023
5076e7b
[AddressLowering] NFC: Moved assert above NPE.
nate-chandler Jul 24, 2023
de8e182
[AddressLowering] Prevent existential multi-init.
nate-chandler Jul 16, 2023
c9d8429
[AddressLowering] Project at storage.
nate-chandler Jul 16, 2023
604150c
[AddressLowering] Place projections below types.
nate-chandler Jan 14, 2023
a27b390
[AddressLowering] Sink projections to uses.
nate-chandler Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/swift/SIL/Dominance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ class DominanceInfo : public DominatorTreeBase {
/// Does value A properly dominate instruction B?
bool properlyDominates(SILValue a, SILInstruction *b);

/// The nearest block which dominates all the uses of \p value.
SILBasicBlock *getLeastCommonAncestorOfUses(SILValue value);

void verify() const;

/// Return true if the other dominator tree does not match this dominator
Expand Down
9 changes: 9 additions & 0 deletions lib/SIL/Utils/Dominance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,15 @@ bool DominanceInfo::properlyDominates(SILValue a, SILInstruction *b) {
return false;
}

SILBasicBlock *DominanceInfo::getLeastCommonAncestorOfUses(SILValue value) {
SILBasicBlock *lca = nullptr;
for (auto *use : value->getUses()) {
auto *block = use->getParentBlock();
lca = lca ? findNearestCommonDominator(lca, block) : block;
}
return lca;
}

void DominanceInfo::verify() const {
// Recompute.
auto *F = getRoot()->getParent();
Expand Down
Loading