Skip to content

[cxx-interop] Emit IR for templated static members with an out-of-line definition #63058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

[cxx-interop] Emit IR for templated static members with an out-of-line definition #63058

merged 1 commit into from
Jan 17, 2023

Conversation

egorzhdan
Copy link
Contributor

This fixes #63055.

rdar://101539308

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Jan 16, 2023
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-templated-static-member branch from ae2bc4d to 0862659 Compare January 17, 2023 11:02
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-templated-static-member branch from 0862659 to 1965e74 Compare January 17, 2023 12:09
egorzhdan added a commit that referenced this pull request Jan 17, 2023
@egorzhdan
Revert "Revert "[cxx-interop] Add conversions between `std::u16string…
a14124a 
…` and `Swift.String`""

This re-lands #61695 since the linker error on CentOS has been fixed in #63058.

This reverts commit e97b1c8
zoecarver
zoecarver approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, Egor!

@egorzhdan egorzhdan merged commit c0e9ebe into main Jan 17, 2023
@egorzhdan egorzhdan deleted the egorzhdan/cxx-templated-static-member branch January 17, 2023 16:58
egorzhdan added a commit that referenced this pull request Feb 1, 2023
@egorzhdan
Revert "Revert "[cxx-interop] Add conversions between `std::u16string…
0ed93b4 
…` and `Swift.String`""

This re-lands #61695 since the linker error on CentOS has been fixed in #63058.

This reverts commit e97b1c8
egorzhdan added a commit that referenced this pull request Feb 22, 2023
@egorzhdan
Revert "Revert "[cxx-interop] Add conversions between `std::u16string…
1910a77 
…` and `Swift.String`""

This re-lands #61695 since the linker error on CentOS has been fixed in #63058.

This reverts commit e97b1c8
egorzhdan added a commit that referenced this pull request Feb 22, 2023
@egorzhdan
Revert "Revert "[cxx-interop] Add conversions between `std::u16string…
9818312 
…` and `Swift.String`""

This re-lands #61695 since the linker error on CentOS has been fixed in #63058.

This reverts commit e97b1c8
@egorzhdan egorzhdan mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver zoecarver approved these changes

@hyp hyp Awaiting requested review from hyp

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linker error when a templated C++ class declares a static out-of-line member
2 participants
@egorzhdan @zoecarver