[Serialization] Public overrides of internal decls are ignorable by clients #63068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lients This change reflects the behavior of `DeclAttribute.printImpl` that prints the `override` keyword in a swiftinterface only when the overriden decl is also public. This issue was detected when working on deserialization safety by public overrides of private functions in the following tests: test/Interpreter/vtables_multifile.swift test/Interpreter/vtables_multifile_testable.swift test/SILGen/accessibility_vtables_testable.swift test/SILGen/accessibility_vtables_usableFromInline.swift test/SILGen/vtables_multifile.swift
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider public overrides of internal decls as ignorable by clients. This change reflects the behavior of
DeclAttribute.printImplthat prints theoverridekeyword in a swiftinterface only when the overriden decl is also public.This logic collaborates with deserialization safety that will reject loading the non-public overriden decl and raise an error, for which this change will make deserialization drop the error and keep the overriding decl.
This issue was detected when working on deserialization safety by public overrides of private functions in the following tests: