Skip to content

[Serialization] Don't serialize macro custom attributes. #63075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

hborla
Copy link
Member

@hborla hborla commented Jan 18, 2023

Once a macro has expanded, we don't need the custom attribute anymore; don't preserve macro custom during serialization. Previously, attempting to serialize a macro custom attribute would crash, because the custom attribute does not have a type.

@hborla
Copy link
Member Author

hborla commented Jan 18, 2023

@swift-ci please smoke test

@hborla hborla merged commit 20f51b2 into swiftlang:main Jan 18, 2023
@hborla hborla deleted the macro-attribute-serialization branch January 18, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant