[Macros] Fix a use-after-free with getSemanticAttrs().
#63076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a request for semantic declaration attributes while still allowing the original linked list to be mutated directly can cause use-after-frees on pointers to old decl attributes. For now, introduce a request that expands member attribute macros with a side effect of adding the new attributes to the list. We can revisit this once attribute mutation via getAttrs() is audited across the frontend.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a request for semantic declaration attributes while still allowing the original linked list to be mutated directly can cause use-after-frees on pointers to old decl attributes. For now, introduce a request that expands member attribute macros with a side effect of adding the new attributes to the list. We can revisit this once attribute mutation via
getAttrs()is audited across the frontend.This change also re-applies the commit reverted in #63062
Resolves: rdar://104297642