[SourceKit] Move demangle/mangle logic to SwfitLangSupport #63111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
sourcektid-mangling-langsupport
branch
from
7e5174d to
9861f8b
Compare
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Jan 19, 2023
'sourcekitd' itself should not call 'swift::' functions. It should just deserialize the request, execute the logic in LangSupport, then serialize the result.
rintaro
force-pushed
the
sourcektid-mangling-langsupport
branch
from
9861f8b to
8d8ec09
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourcekitditself should not callswift::functions. It should just deserialize the request, execute the logic in LangSupport, then serialize the result.