Add default value for ExplicitModuleInfo isFramework #63119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the json file doesn't contain a value for this, this was never set, which results in UB. Unfortunately clang doesn't warn about this but gcc does https://godbolt.org/z/M3sdE73zs
|
@swift-ci please smoke test |
|
I think ideally this value was always provided, but if it isn't this default feels better than UB |
keith
added a commit
to bazelbuild/rules_swift
that referenced
this pull request
Jan 19, 2023
Without this value you get UB swiftlang/swift#63119 This hit us where it defaults to true with Swift 5.7.2 on Ubuntu 22.04, but not on Ubuntu 20.04. I don't think this ever needs to be true for bazel
keith
added a commit
to bazelbuild/rules_swift
that referenced
this pull request
Jan 20, 2023
Without this value you get UB swiftlang/swift#63119 This hit us where it defaults to true with Swift 5.7.2 on Ubuntu 22.04, but not on Ubuntu 20.04. I don't think this ever needs to be true for bazel
|
@swift-ci Please smoke test and merge |
keith
deleted the
ks/add-default-value-for-explicitmoduleinfo-isframework
branch
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
Without this value you get UB swiftlang/swift#63119 This hit us where it defaults to true with Swift 5.7.2 on Ubuntu 22.04, but not on Ubuntu 20.04. I don't think this ever needs to be true for bazel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the json file doesn't contain a value for this, this was never set, which results in UB.
Unfortunately clang doesn't warn about this but gcc does https://godbolt.org/z/M3sdE73zs