Skip to content

Sema: Avoid use @_spi instead diagnostic on nested decls with @_spi_available #63197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

We should avoid suggesting use of @_spi instead of @_spi_available on member declarations since we don't check whether there are relevant @available attributes on the enclosing decl.

Resolves rdar://102443376

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tshortli
Copy link
Contributor Author

@swift-ci please smoke test macOS

@tshortli tshortli merged commit c285bab into swiftlang:main Jan 25, 2023
@tshortli tshortli deleted the avoid-spi-available-diagnostic-on-nested-decls branch January 25, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants