[NameLookup] Opaque Type Collector should skip existential types #63221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela-laar
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
angela-laar
force-pushed
the
verifier-failure-implicit-some
branch
from
e750c0a to
959d833
Compare
hborla
approved these changes
Jan 27, 2023
angela-laar
force-pushed
the
verifier-failure-implicit-some
branch
from
959d833 to
286772a
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
angela-laar
force-pushed
the
verifier-failure-implicit-some
branch
from
7ce4191 to
e0c8a61
Compare
|
@swift-ci please smoke test |
angela-laar
force-pushed
the
verifier-failure-implicit-some
branch
from
e0c8a61 to
a24cf19
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test linux |
Only retrieve parsed opaque generic parameters and not synthsized opaque generic parameters.
Do this for implicit param declarations
angela-laar
force-pushed
the
verifier-failure-implicit-some
branch
from
a24cf19 to
cba7389
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error in the opaque type collector is causing basic code using existential 'any' to crash with the 'ImplicitSome' feature.
i.e.
Fixes rdar://102698119