Skip to content

Update llvm::Optional API uses #63227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2023
Merged

Update llvm::Optional API uses #63227

merged 1 commit into from
Jan 26, 2023

Conversation

bnbarham
Copy link
Contributor

Use the std-equivalent names as the LLVM ones are now deprecated (eventually llvm::Optional will disappear):

  • getValue -> value
  • getValueOr -> value_or
  • hasValue -> has_value

Follow up from ab1b343 and 7d8bf37 with some missing cases.

@bnbarham
Update llvm::Optional API uses
3ec878d 
Use the std-equivalent names as the LLVM ones are now deprecated
(eventually `llvm::Optional` will disappear):
  - `getValue` -> `value`
  - `getValueOr` -> `value_or`
  - `hasValue` -> `has_value`

Follow up from ab1b343 and
7d8bf37 with some missing cases.
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham merged commit 4380ee6 into swiftlang:main Jan 26, 2023
@bnbarham bnbarham deleted the optional-api-update branch January 26, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi CodaFi approved these changes

@ahoppen ahoppen ahoppen approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnbarham @CodaFi @ahoppen