Skip to content

[TypeResolution] Remove unnecessary parameter pack special case from function type resolution. #63256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

hborla
Copy link
Member

@hborla hborla commented Jan 27, 2023

This code is a remnant from when parameter packs and classic variadic parameters both used the '...' syntax. Now, parameter packs can use the standard resolveType code path.

…function

type resolution.

This code is a remnant from when parameter packs and classic variadic parameters
both used the '...' syntax. Now, parameter packs can use the standard 'resolveType'
code path.
@hborla
Copy link
Member Author

hborla commented Jan 27, 2023

@swift-ci please smoke test

@sophiapoirier
Copy link
Contributor

I wonder whether maybeResolvePackExpansionType as a distinct method even should exist with this change, or just be incorporated into resolvePackExpansionType?

@hborla
Copy link
Member Author

hborla commented Jan 27, 2023

@sophiapoirier you're right, maybeResolvePackExpansionType seems completely unnecessary now! I'll fold it into resolvePackExpansionType

@hborla
Copy link
Member Author

hborla commented Jan 27, 2023

@swift-ci please smoke test

@hborla hborla merged commit be00ae8 into swiftlang:main Jan 27, 2023
@hborla hborla deleted the function-parameter-pack-resolution branch January 27, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants