[move-only] Rather than calling the borrow to destructure transform from the MoveOnlyObjectChecker, make its own pass. #63270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom the MoveOnlyObjectChecker, make its own pass. This is a cleaner separation of concerns. The reason why I did not do this originally is that I thought I would need to reuse this functionality in the address checker, but this issue actually does not come up there since we project the address and then load instead of load and then project.
|
@swift-ci smoke test |
|
Windows failure is something in concurrency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner separation of concerns. The reason why I did not do this originally is that I thought I would need to reuse this functionality in the address checker, but this issue actually does not come up there since we project the address and then load instead of load and then project.