build: Override default build variant for --xcode
#63271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this line needed if we set the default in |
|
@swift-ci python lint |
AnthonyLatsis
added
build-script
xedin
approved these changes
Jan 30, 2023
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
shahmishal
reviewed
Jan 31, 2023
| @@ -357,7 +357,7 @@ while retaining the option of building with Ninja on the command line. | |||
|
|
|||
| Assuming that you have already [built the toolchain via Ninja](#the-actual-build), | |||
| several more steps are necessary to set up this environment: | |||
| * Generate Xcode projects with `utils/build-script --release --swift-darwin-supported-archs "$(uname -m)" --xcode --clean`. | |||
| * Generate Xcode projects with `utils/build-script --swift-darwin-supported-archs "$(uname -m)" --xcode --clean`. | |||
There was a problem hiding this comment.
Do you know why we need to pass this flag?
--swift-darwin-supported-archs
@edymtt might have more insight.
There was a problem hiding this comment.
For the Xcode generator? Yes, because of errors like this one:
CMake Error in SwiftCompilerSources/CMakeLists.txt:
The custom command generating
/Users/mac/Desktop/swift-project/build/Xcode-DebugAssert/swift-macosx-x86_64/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/swift/macosx/x86_64/libcxxshim.modulemap
is attached to multiple targets:
lib-swift-macosx-arm64-libcxxshim.modulemap
lib-swift-macosx-x86_64-libcxxshim.modulemap
but none of these is a common dependency of the other(s). This is not
allowed by the Xcode "new build system".
multiple targets not supported by Xcode
shahmishal
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #62156.