Skip to content

[Dependency Scanning] Treat '-embed-tbd-for-module' modules as implicit import dependencies. #63272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jan 27, 2023

Otherwise the scanning action will not look for them as dependencies, and the compilation it is used to inform will not specify these moduels as explicit inpouts.

Resolves rdar://104761392

…it import dependencies.

Otherwise the scanning action will not look for them as dependencies, and the compilation it is used to inform will not specify these moduels as explicit inpouts.

Resolves rdar://104761392
@artemcm artemcm requested review from xymus and nkcsgexi January 27, 2023 22:48
@artemcm
Copy link
Contributor Author

artemcm commented Jan 27, 2023

@swift-ci test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@artemcm
Copy link
Contributor Author

artemcm commented Jan 28, 2023

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jan 28, 2023

@swift-ci test macOS platform

@artemcm artemcm merged commit 4665053 into swiftlang:main Jan 30, 2023
@artemcm artemcm deleted the EmbedTBDImplicitDependenciesForExplicitGoodness branch January 30, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants