Skip to content

[DiagnosticsQoI] Sema: Use 'underlying' instead of 'concrete' in opaque result type diagnostic #63287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

[DiagnosticsQoI] Sema: Use 'underlying' instead of 'concrete' in opaque result type diagnostic #63287

merged 1 commit into from
Jan 30, 2023

Conversation

AnthonyLatsis
Copy link
Collaborator

For the sake of consistency. See comment.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

LucianoPAlmeida
LucianoPAlmeida approved these changes Jan 29, 2023
View reviewed changes
Copy link
Contributor

@LucianoPAlmeida LucianoPAlmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'd let @xedin have the final word

xedin
xedin approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underlying indeed fits better here!

@xedin
Copy link
Contributor

xedin commented Jan 30, 2023

@swift-ci please smoke test Windows platform

@AnthonyLatsis AnthonyLatsis merged commit 07db94b into swiftlang:main Jan 30, 2023
@AnthonyLatsis AnthonyLatsis deleted the opaque-result-diag branch January 30, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@LucianoPAlmeida LucianoPAlmeida LucianoPAlmeida approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnthonyLatsis @xedin @LucianoPAlmeida