[Macros] Use macro expansion mangling for unique names in macros #63322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
rintaro and
zoecarver
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Add frontend flag `-emit-macro-expansion-files diagnostics` to emit any macro expansion buffers referenced by diagnostics into files in a temporary directory. This makes debugging type-checking failures in macro expansions far easier, because you can see them after the compiler process has exited.
This feature is too handy to leave off-by-default. Enable it by default, but allow `-emit-macro-expansion-files no-diagnostics` to disable it.
Use the name mangling scheme we've devised for macro expansions to back the implementation of the macro expansion context's `getUniqueName` operation. This way, we guarantee that the names provided by macro expansions don't conflict, as well as making them demangleable so we can determine what introduced the names.
DougGregor
force-pushed
the
macro-expansion-unique-name-mangling
branch
from
834864f to
6905bc0
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the name mangling scheme we've devised for macro expansions to
back the implementation of the macro expansion context's
getUniqueNameoperation. This way, we guarantee that the namesprovided by macro expansions don't conflict, as well as making them
demangleable so we can determine what introduced the names.