[5.8][Concurrency] Add include of unistd.h to TaskGroup.cpp #63344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://104758975
Missing import caused build failures:
```
stdlib/public/Concurrency/TaskGroup.cpp:572:11: error: use of undeclared identifier 'STDERR_FILENO'
write(STDERR_FILENO, message, strlen(message));
^
```
ktoso
requested review from
hborla,
slavapestov,
xedin,
shahmishal,
al45tair,
zoecarver,
hyp,
egorzhdan,
eeckstein and
artemcm
as code owners
|
@swift-ci please test |
ktoso
added
concurrency
DougGregor
approved these changes
Feb 1, 2023
drexin
approved these changes
Feb 1, 2023
|
@swift-ci please test |
drexin
requested changes
Feb 2, 2023
rdar://104967560
|
@swift-ci please test |
|
Resolves rdar://104967560 |
drexin
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This fixes compilation in the SWIFT_CONCURRENCY_TASK_TO_THREAD_MODEL, which was not caught in CI because CI does not verify this configuration. We fixed this on main here: #63265 and should have the same fix on 5.8 to avoid a surprise in case we'd want to use this mode in 5.8.
Risk: Low
Review by: @DougGregor @drexin
Testing: CI testing
Original PR: #63265
Radar: rdar://104758975 rdar://104967560