Skip to content

[SE-0376] Rename @_backDeploy(before:) to @backDeployed(before:) #63357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Feb 1, 2023

Update the spelling of the @_backDeploy(before:) attribute to @backDeployed(before:) in accordance with the resolution of SE-0376.

For now, swiftinterfaces will continue to print the attribute as @_backDeploy(before:) since the older compilers cannot parse the new spelling.

The corresponding swift-syntax PR is: swiftlang/swift-syntax#1304

Resolves rdar://102792909

@tshortli
Copy link
Contributor Author

tshortli commented Feb 1, 2023

swiftlang/swift-syntax#1304

@swift-ci please test

@benrimmington

This comment was marked as resolved.

@tshortli tshortli force-pushed the se0376-rename-backdeploy branch from 760d209 to d44c9f2 Compare February 2, 2023 06:04
@tshortli tshortli changed the title Finalize SE-0376 [SE-0376] Rename @_backDeploy(before:) to @backDeployed(before:) Feb 2, 2023
@tshortli
Copy link
Contributor Author

tshortli commented Feb 2, 2023

CHANGELOG.md

  • The example code could use syntax highlighting.
  • It may also need an @available above the extension.
  • The degreesCelcius should be degreesCelsius.
  • A reference (at the end of the file) is needed.

Thanks, I fixed all of these except for the omission of availability on the extension which was intentional. It is common in SDK modules for extensions to be declared without availability and to instead annotate each member individually, which I want to do in the example for clarity.

@tshortli tshortli marked this pull request as ready for review February 2, 2023 06:12
@tshortli
Copy link
Contributor Author

tshortli commented Feb 2, 2023

swiftlang/swift-syntax#1304

@swift-ci please test

@tshortli tshortli added swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process and removed swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process labels Feb 2, 2023
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tshortli tshortli merged commit 8fde58f into swiftlang:main Feb 2, 2023
@tshortli tshortli deleted the se0376-rename-backdeploy branch February 2, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants