Skip to content

[5.8][stdlib] NFC: Restore doc comment for Unsafe[Mutable]BufferPointer #63362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

krilnon
Copy link
Member

@krilnon krilnon commented Feb 2, 2023

Description: Cherry picks #63288 onto release/5.8. Removes a // comment from below a /// documentation comment, since the latter needs to be attached directly to the declaration or it won't be picked up as documentation.
Risk: Low
Review by: @stephentyrone @airspeedswift
Testing: CI testing
Original PR: #63288
Radar: rdar://104937379

[stdlib] NFC: Restore doc comment for Unsafe[Mutable]BufferPointer

(cherry picked from commit 124b098)
@krilnon
Copy link
Member Author

krilnon commented Feb 2, 2023

@swift-ci please test

Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change suggested by this FIXME is no longer useful (or feasible). Removing should fix the documentation generated by docc, but it also removes stale information.

@glessard glessard merged commit 62b24df into release/5.8 Feb 10, 2023
@glessard glessard deleted the krilnon/pick-krilnon-unsafe-buffer-pointer-docs branch February 10, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants