[IRGen] Lowered open_pack_element. #63363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
variadic-generics/irgen/open_pack_element
branch
from
2451aee to
2141a70
Compare
nate-chandler
force-pushed
the
variadic-generics/irgen/open_pack_element
branch
from
2141a70 to
4128050
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
variadic-generics/irgen/open_pack_element
branch
from
4128050 to
3fa849e
Compare
|
@swift-ci please test |
rjmccall
reviewed
Feb 2, 2023
lib/IRGen/GenProto.cpp
Outdated
| case GenericRequirement::Kind::Metadata: { | ||
| CanGenericTypeParamType ty; | ||
| if ((ty = dyn_cast<GenericTypeParamType>(requirement.getTypeParameter())) && | ||
| ty->isParameterPack()) |
There was a problem hiding this comment.
We might see this kind of requirement for associated types of packs, too, right?
You should have enough information to set the requirement kind as MetadataPack / WitnessTablePack in the first place, and that'll probably make clients of this a lot easier.
There was a problem hiding this comment.
Added these new kinds in 6a44de2 . Does the static member function GenericRequirement::isPack added there correctly identify which types are packs?
nate-chandler
force-pushed
the
variadic-generics/irgen/open_pack_element
branch
from
3fa849e to
e3daab3
Compare
The mapping from requirement kind to llvm::Type is repeated several places. Pull it into a helper.
Added pack flavors of requirement kinds for metadata and witness tables. Fixes the function signatures for variadic generic functions which previously used %swift.type* for variadic generic parameters--those are lists of metadata and should actually be %swift.type**.
The function emits the metadata for the element of a pack expansion at a specified index. It was previously defined inline in the loop--defined in emitPackExpansionType--which populates a new metadata array with elements derived from a preexisting array. It will be used to emit a single element in the case that only one is needed.
The parameter name to emitPackExpansionElementMetadata matched the preexisting local variable name. Change it to something meaningful to callers. Use a separate commit to make the original extraction more obviously just an extraction.
nate-chandler
force-pushed
the
variadic-generics/irgen/open_pack_element
branch
from
e3daab3 to
a442245
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial lowering support for the open_pack_element instruction. While lowering,
binds
(@pack_element(...) U_i)to the typeT(i, %index)at%indexinPack_ifor alliof the appropriate shape.Materialize the metadata address for
T(i, %index)depending on what's already available. In general, compare the %index to the upper bound of each element's range: if it's in range, emit the metadata at%innerIndex := %index - %innerLowerBound; if it's out of range, jump to the next comparison. From each metadata emission block, jump to a merge point where the result metadata is defined to be the phi of the metadata materialized in each predecessor.Still to do: handle conformances.