Skip to content

[Macros] Miscellaneous fixes for accessor and member macros #63370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2023
Merged

[Macros] Miscellaneous fixes for accessor and member macros #63370

merged 2 commits into from
Feb 2, 2023

Conversation

DougGregor
Copy link
Member

  • When an accessor macro produces a non-observing accessor, remove the initializer
  • Make sure we don't forget to serialize macro roles

@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

@DougGregor
Copy link
Member Author

@swift-ci please smoke test Linux

@DougGregor DougGregor merged commit 2f3b51a into swiftlang:main Feb 2, 2023
@DougGregor DougGregor deleted the accessor-member-macro-fixes branch February 2, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DougGregor