Skip to content

[move-only][no-implicit-copy] Some small fixes #63392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2023
Merged

[move-only][no-implicit-copy] Some small fixes #63392

merged 3 commits into from
Feb 3, 2023

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Feb 2, 2023

Specifically:

  1. Adding a test that I forgot to upstream.
  2. Fixing a small issue where when given a no-copy noimplicitcopy, we were not eliminating the early copy_value due to pattern matching expecting a normal move-only type.
  3. I enabled sił-verify-all on the no implicit copy tests since they are clean.

@gottesmm
Add a test that was missing when I added code that turned off the bor…
282164c 
…row to destructure transform for no implicit copy.
@gottesmm
[no-implicit-copy] Make sure that we eliminate initial copy_value fro…
0986bd0 
…m [no_copy] cases like we do for moveonly.

Just missed pattern matching the copyable_to_moveonlywrapper at the beginning of
the initialization sequence.

rdar://104935447
@gottesmm
[noimplicitcopy] Enable sil-verify-all on no implicit copy tests.
37024f1 
rdar://104935849
@gottesmm
Copy link
Contributor Author

gottesmm commented Feb 2, 2023

@swift-ci smoke test

@gottesmm gottesmm merged commit c6942ee into swiftlang:main Feb 3, 2023
@gottesmm gottesmm deleted the pr-edebfaea60c9ef3f6834b82c2f5155097c04c93b branch February 3, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gottesmm