[5.8][RequirementMachine] Skip Sendable conformance requirements from @preconcurrency declarations in requirement inference.
#63493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oncurrency declarations in requirement inference.
…econcurrency decls if the decl we're inferring the generic signature for is not itself preconcurrency.
|
@swift-ci please test |
airspeedswift
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Currently,
@preconcurrencyannotations can break client ABI through inference of newSendableconformance requirements. This change teaches requirement inference to dropSendableconformance requirements from inference sources that are@preconcurrencydeclarations unless the destination declaration is itself@preconcurrency.Scope: This change is critical for frameworks auditing APIs for concurrency. It only affects generic types or protocols marked with
@preconcurrency.Risk: Low.
Testing: Added unit tests.
Reviewer: @DougGregor
Resolves: rdar://104129992