Skip to content

Demangle an OpaqueArchetypeTypeRef's ID as a type not as a symbol #63508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

augusto2112
Copy link
Contributor

@augusto2112 augusto2112 commented Feb 8, 2023

(cherry picked from commit e2febea)

rdar://104982758

Cherry-pick of https://github.com/apple/swift/pull/61091


  • Explanation:

Fix a bug which would crash the demangler when trying to process opaque types when used from remote mirrors.

For example, when debugging the following code in LLDB:

protocol P {}

struct S: P {}

struct A<T> {
  let t: T
}
let p: some P = S()
let a = A(t: p)
print(1) // Stop here, run "v a"
}

The demangler will crash when trying to demangle the type of t without this change

@augusto2112 augusto2112 requested a review from a team as a code owner February 8, 2023 00:02
@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@augusto2112
Copy link
Contributor Author

@swift-ci test

@augusto2112
Copy link
Contributor Author

@swift-ci nominate

@augusto2112
Copy link
Contributor Author

@swift-ci please nominate

@augusto2112 augusto2112 merged commit 3ec56ba into swiftlang:release/5.8 Feb 8, 2023
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants