Skip to content

[IRGen] Lowered de/alloc_pack. #63513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

Lowered to dynamic or static allocation of getPackElementSize() * count.

@nate-chandler nate-chandler force-pushed the variadic-generics/irgen/alloc_pack branch from fb85d9d to 18dd471 Compare February 8, 2023 04:44
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Made TypeBase's implementation dispatch to the implementation specific
to SILPackType.
@xedin xedin removed their request for review February 8, 2023 21:26
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the test thing

@nate-chandler nate-chandler force-pushed the variadic-generics/irgen/alloc_pack branch from 18dd471 to 2118ad3 Compare February 9, 2023 15:22
@nate-chandler nate-chandler force-pushed the variadic-generics/irgen/alloc_pack branch from 2118ad3 to da5b5c1 Compare February 9, 2023 15:24
@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test

@nate-chandler nate-chandler merged commit 3b4d03c into swiftlang:main Feb 9, 2023
@nate-chandler nate-chandler deleted the variadic-generics/irgen/alloc_pack branch February 9, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants