[IRGen] Lowered tuple_pack_element_addr. #63532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the preexisting function loadTupleOffsetFromMetadata--which took an unsigned index and constructed an llvm::Value from it--to instead take a llvm::Value. Preserved the old overload to just pass through to the refactored function.
nate-chandler
force-pushed
the
variadic-generics/irgen/tuple_pack_element_addr
branch
from
d3cf221 to
d023e02
Compare
|
@swift-ci please test |
rjmccall
reviewed
Feb 9, 2023
nate-chandler
force-pushed
the
variadic-generics/irgen/tuple_pack_element_addr
branch
from
d023e02 to
7acc339
Compare
|
@swift-ci please smoke test and merge |
|
I think that this is causing instability on Windows due to stack corruption. |
|
@compnerd Any idea how that might be happening? I was hoping it was NFC for non-variadic-generic code. |
|
That would be due to the use of the |
|
Thanks, @compnerd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalized preexisting
loadTupleOffsetFromMetadatafunction to take anllvm::Value *rather than an unsigned and used it to get the offset specified by the dynamic index.