EscapeUtils: fix some bugs related to followLoads
#63614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fects. Exclusive argument -> argument effects cannot appear because such an effect would involve a store which is not permitted for exclusive escapes.
… effects * Disallow stores in the return -> argument path. When walking up in the EscapeUtils, it's allowed to follow stores. Therefore stores wouldn't be handled correctly. * Also make sure that there is a return -> argument path at all Fixes a wrong address-escaping effect in case the called function copies an indirect argument to a newly created object. rdar://105133434
…guments This is the only apply instruction where address arguments actually can "escape"
When walking up we shouldn't end up at a load where followLoads is false, because going from a (non-followLoads) address to a load always involves a class indirection. There is one exception: loading a raw pointer
|
@swift-ci test |
|
@swift-ci benchmark |
eeckstein
changed the title
followLoads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
begin_applycan yield it's indirect argumentsFor details see the commit messages
Fixes a wrong address-escaping effect in case the called function copies an indirect argument to a newly created object.
rdar://105133434