Disable stack protection by default #63661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://105231457
tbkka
approved these changes
Feb 14, 2023
|
@swift-ci Please test |
|
@swift-ci Please test macOS platform |
|
First macOS test attempt failed with "cannot connect to server", so I started a new test. |
|
@swift-ci Please test macOS |
|
Can we please get more context in the PR description? This looks bad out of context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: Stack protection was added to the
mainbranch a few months ago and has not yet been in any shipping version of Swift.We expect stack checks to impair performance somewhat, but we've recently found some cases where the stack checks were being inserted in places where they don't actually do any good. These led to unnecessary performance regressions, so we're disabling them in the 5.8 branch.
We'll leave it enabled in
mainwhile we work to avoid the extra unnecessary stack checks.Resolves rdar://105231457