[GenPack] Emit all element signature requirements. #63665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
rjmccall
reviewed
Feb 15, 2023
And updated the isMetadata and isWitnessTable predicates to count packs of either.
Enumerate the requirements of opened element signature and emit metadata and witness tables for each *Pack requirement.
Previously, the test didn't actually verify that the called witness method was the witness method from the right method--all the methods had the same implementation and just forwarded the type along to be printed. Now an id specific to each method is printed as well.
nate-chandler
force-pushed
the
variadic-generics/irgen/full_metadata_binding
branch
from
f889111 to
c5563ff
Compare
|
@swift-ci please test |
nate-chandler
deleted the
variadic-generics/irgen/full_metadata_binding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumerate the requirements of opened element signature and emit metadata and witness tables for each
*Packrequirement.