SILOptimizer: avoid stack protection in two cases where it's not needed #63676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's like `Builtin.stackAlloc`, but doesn't set the `[stack_protection]` flag on its containing function.
eeckstein
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
This function is similar to `withUnsafeTemporaryAllocation`, except that it doesn't trigger stack protection for the stack allocated memory.
Stack protection only protects against overflows, but not against out of bounds reads. rdar://105231457
eeckstein
force-pushed
the
improve-stack-protection
branch
from
83164fc to
abf9900
Compare
|
@swift-ci test |
eeckstein
requested review from
glessard
and removed request for
xedin,
slavapestov and
hborla
glessard
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadUnaligneddoesn't need stack protection for it's temporaryrdar://105231457