[gardening] Make sure FieldRecordFlags.Data never contains uninitialized data #6368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zed data This will silence the warning "The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage."
|
@swift-ci please smoke test |
|
@slavapestov or @DougGregor, would you mind reviewing this? :-) |
|
I don't believe I we will we ever construct one of these; they are only reinterpret_cast-ed from metadata that is emitted by IRGen. Might be better to delete the default constructor, if that also silences the warning. The initialization won't hurt, though. |
|
@bitjammer I tried that but stumbled on a a call to the default constructor of I'm going ahead with the initialization to get rid of the warning for now. |
|
Ah yeah, you're right, it looks like we are using it for metadata emission in one place and it is using the default constructor, so it's all good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will silence the warning "The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage."
This should probably be reviewed by @bitjammer or @slavapestov :-)