[cxx-interop] Add CxxOptional protocol for std::optional ergonomics
#63683
Conversation
egorzhdan
requested review from
zoecarver,
hyp,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-optional
branch
from
029f75b to
e3acf24
Compare
|
@swift-ci please smoke test |
stdlib/public/Cxx/CxxOptional.swift
Outdated
| } | ||
|
|
||
| extension Optional { | ||
| public init<O: CxxOptional>(fromCxx value: O) where O.Wrapped == Wrapped { |
There was a problem hiding this comment.
@lorentey Karoy, could you please take a look to see if the signature of this initializer looks reasonable, specifically the fromCxx label?
I couldn't make this initializer unlabeled, since Swift.Optional already has an unlabeled initializer that wraps around the passed object, which isn't what we'd like to happen here.
There was a problem hiding this comment.
It looks okay! Naming is difficult as usual, but fromCxx is plausible, and if we figure out a better convention, keeping this one around will not hurt much.
| } | ||
|
|
||
| extension CxxOptional { | ||
| public var hasValue: Bool { |
There was a problem hiding this comment.
This property provides the only way to check if the std::optional has a value from Swift.
egorzhdan
force-pushed
the
egorzhdan/cxx-optional
branch
from
e3acf24 to
6672cd3
Compare
|
@swift-ci please smoke test |
This adds a protocol to the C++ standard library overlay which will improve the ergonomics of `std::optional` when used from Swift code. As of now, the overlay adds an initializer of `Swift.Optional` that takes an instance of `CxxOptional` as a parameter.
egorzhdan
force-pushed
the
egorzhdan/cxx-optional
branch
from
6672cd3 to
a12986a
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
This adds a protocol to the C++ standard library overlay which will improve the ergonomics of
std::optionalwhen used from Swift code.As of now, the overlay adds an initializer of
Swift.Optionalthat takes an instance ofCxxOptionalas a parameter.