AST: Print the custom attributes attached to AttributedTypeRepr
#63701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that global actor attributes are included when printing a `TypeRepr` representing a global actor bound function type. Resolves rdar://105475701
tshortli
requested review from
DougGregor
and removed request for
xedin,
slavapestov and
hborla
tshortli
commented
Feb 16, 2023
| @@ -218,6 +218,15 @@ void AttributedTypeRepr::printAttrs(ASTPrinter &Printer, | |||
| Printer.printSimpleAttr("@autoclosure") << " "; | |||
| if (hasAttr(TAK_escaping)) | |||
| Printer.printSimpleAttr("@escaping") << " "; | |||
|
|
|||
| for (auto customAttr : Attrs.getCustomAttrs()) { | |||
There was a problem hiding this comment.
I wasn't sure whether it might make sense to try to specifically find the global actor attribute here and print it individually, rather than all of the custom attributes all at once. In the future when there are multiple kinds of attributes we might want to print each possible custom attribute kind in a stable order.
|
@swift-ci please test |
DougGregor
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
LGTM. @hborla or I will need to follow this up with some suppression rules for macros, because macros are custom attributes that aren't rendered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that global actor attributes are included when printing a
TypeReprrepresenting a global actor bound function type.Resolves rdar://105475701