[IDE] Check whether an AST node contains the IDE inspection point based on CharSourceRange
#63714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
hborla,
xedin,
slavapestov,
bnbarham,
CodaFi and
DougGregor
as code owners
|
@swift-ci Please smoke test |
bnbarham
reviewed
Feb 16, 2023
| return IDEInspectionTargetBufferID | ||
| ? rangeContainsTokenLoc(R, getIDEInspectionTargetLoc()) | ||
| : false; | ||
| bool rangeContainsIDEInspectionTarget(CharSourceRange R) const { |
There was a problem hiding this comment.
Why can't we take a SourceRange and call Lexer::getCharSourceRangeFromSourceRange here rather than having to pass it in everywhere?
There was a problem hiding this comment.
Because the Basic library can’t depend on Lexer.
ahoppen
force-pushed
the
ahoppen/ideinspectiontarget-charsourcerange
branch
from
49eb4d6 to
afd620e
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
ahoppen/ideinspectiontarget-charsourcerange
branch
from
afd620e to
8b51ef6
Compare
|
@swift-ci Please smoke test |
xedin
approved these changes
Feb 17, 2023
| @@ -126,6 +126,14 @@ class CompletionContextFinder : public ASTWalker { | |||
| } | |||
| }; | |||
|
|
|||
|
|
|||
| /// Returns \c true` if \p range is valid and contains the IDE inspection | |||
…ed on `CharSourceRange` This fixes an issue if the range ends with a string literal that contains the IDE inspection target. In that case the end of the range will point to the start of the string literal but the IDE inspection target is inside the string literal and thus after the range’s end.
ahoppen
force-pushed
the
ahoppen/ideinspectiontarget-charsourcerange
branch
from
8b51ef6 to
8bdf68d
Compare
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue if the range ends with a string literal that contains the IDE inspection target. In that case the end of the range will point to the start of the string literal but the IDE inspection target is inside the string literal and thus after the range’s end.