build-script-impl: Remove dead code that expects an LLVM product #63745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
AnthonyLatsis
force-pushed
the
build-script-impl-cleanup
branch
from
3edb2f5 to
00453c1
Compare
AnthonyLatsis
changed the title
|
@swift-ci please test |
MaxDesiatov
reviewed
Feb 17, 2023
AnthonyLatsis
force-pushed
the
build-script-impl-cleanup
branch
from
00453c1 to
bd59b4d
Compare
|
@swift-ci please test |
AnthonyLatsis
force-pushed
the
build-script-impl-cleanup
branch
from
bd59b4d to
051bf3c
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
Are we ready to ship this? |
compnerd
approved these changes
Mar 1, 2023
utils/build-script-impl
Outdated
Comment on lines
2631
to
2634
| # Even if builds are skipped, Swift configuration relies on | ||
| # some LLVM tools like TableGen. In the LLVM configure rules | ||
| # above, a small subset of LLVM build_targets are selected | ||
| # when SKIP_BUILD is set. |
There was a problem hiding this comment.
Right, apparently not.
AnthonyLatsis
force-pushed
the
build-script-impl-cleanup
branch
from
051bf3c to
920d05b
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM is a build-script product now.
The only thing that makes me doubt this change is the
--legacy-implbuild-script flag, although analogous cleanups were done in the past regardless of its existence.