[CS] Add contextual Bool type to switch-case where clause
#63747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
xedin and
slavapestov
as code owners
xedin
approved these changes
Feb 17, 2023
| func issue63746() { | ||
| let fn = { | ||
| switch 0 { | ||
| case 1 where 0: // expected-error {{type 'Int' cannot be used as a boolean; test for '!= 0' instead}} |
There was a problem hiding this comment.
As an aside, this fix-it is useless for literals.
There was a problem hiding this comment.
Heh yeah, filed #63753
All but one client wants to set this to anything other than `FreeTypeVariableBinding::Disallow`.
Seems this was accidentally omitted, which would crash in CSApply for any non-Bool-convertible type.
hamishknight
force-pushed
the
oh-bool
branch
from
2256727 to
f7191b3
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems this was accidentally omitted, which would crash in CSApply for any non-Bool-convertible type.
Resolves #63746