[IDE] Compute type relations for attributes for generic property wrapper types #63752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per types The existing logic to check whether a type is a valid property wrapper only worked for nominal types, not generic types. Also consider generic types.
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Feb 17, 2023
| @@ -27,7 +27,7 @@ using TypeRelation = CodeCompletionResultTypeRelation; | |||
| /// Returns the kind of attributes \c Ty can be used as. | |||
| static OptionSet<CustomAttributeKind> getCustomAttributeKinds(Type Ty) { | |||
| OptionSet<CustomAttributeKind> Result; | |||
| if (auto NominalTy = Ty->getAs<NominalType>()) { | |||
| if (auto NominalTy = Ty->getAs<NominalOrBoundGenericNominalType>()) { | |||
There was a problem hiding this comment.
Ah that's unfortunate. Thanks for the quick fix!
rintaro
approved these changes
Feb 17, 2023
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic to check whether a type is a valid property wrapper only worked for nominal types, not generic types. Also consider generic types, e.g.
State.rdar://101781129