IRGen: consider deployment target when emitting $ld$previous symbols #63757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment target can be set before the introduction of a moved symbol. When that happens, using the introductory version in the $ld$previous symbol could lead to ld not redirecting the linkage path to the original dylib, which is a mistake when running the App on newer OSs when the original dylib does exist. rdar://105181824
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum deployment target can be set before the introduction of a moved symbol. When that happens, using the introductory version in the
$ld$previoussymbol could lead to ld not redirecting the linkage path to the original dylib, which is a mistake when running the App on newer OSs when the original dylib does exist.rdar://105181824