[CSGen] SE-0213: Literal initialization via coercion shouldn't try br… #63762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idging `addExplicitConversionConstraint` generates a disjunction to check whether type could be coerced via bridging. That is not useful for literal initialization which could use direct equality if the type of cast is valid because necessary conformance checks have been performed before the transformation.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
commented
Feb 17, 2023
| // CHECK: Type Variables: | ||
| // CHECK: [[LITERAL_VAR]] [allows bindings to: {{.*}}] as UInt32 {{.*}} | ||
| // CHECK-NOT: disjunction (remembered) \[\[locator@{{.*}} [Coerce@{{.*}}\]\]]: | ||
| _ = UInt32(0) |
There was a problem hiding this comment.
Note that this could have been a unit test but unfortunately CoerceExpr::forLiteralInit depends on valid source locations...
|
@swift-ci please test macOS platform |
|
@swift-ci please test source compatibility |
|
@swift-ci please test macOS platform |
hborla
approved these changes
Feb 27, 2023
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…idging
addExplicitConversionConstraintgenerates a disjunction tocheck whether type could be coerced via bridging. That is not
useful for literal initialization which could use direct equality if
the type of cast is valid because necessary conformance checks
have been performed before the transformation.