Type reconstruction for variadic generics #63789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
type-reconstruction-for-variadic-generics
branch
from
2032496 to
c4aa820
Compare
|
@swift-ci Please smoke test |
…t pack generic parameters
Also stub out the corresponding entry points in the runtime's MetadataBuilder and the Remote Mirrors TypeRefBuilder.
slavapestov
force-pushed
the
type-reconstruction-for-variadic-generics
branch
from
c4aa820 to
d8f7959
Compare
|
@swift-ci Please smoke test |
slavapestov
requested review from
AnthonyLatsis,
hborla and
xedin
as code owners
slavapestov
added a commit
to slavapestov/swift
that referenced
this pull request
Feb 24, 2023
…eric signature PR swiftlang#63789 introduced verification of the generic parameters appearing in debug info, but I missed an edge case where we have to push a different generic signature. Fixes swiftlang#63869.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://105245884 and rdar://105020048.