[IRGen] Generate compressed representation of value witnesses #63813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er of increments at runtime
…and metadata pointers
|
@swift-ci test |
drexin
commented
Feb 21, 2023
| @@ -58,6 +58,7 @@ copied, but do not need to be released or retained. | |||
| I16 = 's', | |||
There was a problem hiding this comment.
This whole file is outdated and should be removed/replaced with the current design
|
@mikeash Could you take a look at the Metadata ABI related changes? |
drexin
force-pushed
the
wip-bytecode-witnesses-cleanup
branch
from
461e909 to
2081478
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
mikeash
requested changes
Feb 22, 2023
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
|
@swift-ci test |
| @@ -4430,6 +4430,12 @@ ExtendedExistentialTypeCacheEntry::getOrCreateVWT(Key key) { | |||
| swift_unreachable("shape with unknown special kind had no suggested VWT"); | |||
| } | |||
|
|
|||
| const uint8_t * | |||
| ExtendedExistentialTypeCacheEntry::getOrCreateTypeLayout(Key key) { | |||
There was a problem hiding this comment.
This is okay because we don't access the type layout string today in this case?
There was a problem hiding this comment.
Yes, I changed it to nullptr.
aschwaighofer
requested changes
Feb 23, 2023
There was a problem hiding this comment.
LGTM with fixes for the two issues pointed out in various reviews:
- We should make sure that the metadata's type layout string is address-discriminated signed
- We need to make sure that we are doing the right thing with multi-payload enums which use spare bits for the tag
drexin
force-pushed
the
wip-bytecode-witnesses-cleanup
branch
from
11f5b16 to
171e461
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test macos |
|
@swift-ci test |
aschwaighofer
approved these changes
Feb 24, 2023
mikeash
approved these changes
Feb 24, 2023
|
@swift-ci smoke test macos |
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Feb 26, 2023
…thods.sil for changed layout of type metadata after swiftlang#63813
swift-ci
added a commit
that referenced
this pull request
Feb 26, 2023
…anged_full_typemetadata_layout Adjust test/IRGen/ptrauth-foreign.sil and test/IRGen/ptrauth-class-methods.sil for changed layout of type metadata after #63813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://105837040