Skip to content

[test] disable test for simulators #63818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

glessard
Copy link
Contributor

Disable this test for simulators, where it's been failing since Feb 19, 2023 10:34:19 PM.

@glessard
Copy link
Contributor Author

@swift-ci please smoke test

@glessard
Copy link
Contributor Author

This is related to rdar://105651154

@adrian-prantl
Copy link
Contributor

If we know which commit caused this, could we revert that commit instead?

@glessard
Copy link
Contributor Author

I don't know which commit – I don't have experience with that part of the code base. If you can identify it, we could try that…

@glessard
Copy link
Contributor Author

@swift-ci please smoke test linux platform

@glessard
Copy link
Contributor Author

Test failure occurred later than this change, and testDebugInfo/basic.swift ran and passed.

@glessard glessard merged commit 5a3220e into swiftlang:main Feb 22, 2023
@glessard
Copy link
Contributor Author

@adrian-prantl Assuming that this isn't the correct fix, please revert this change when rdar://105651154 is fixed.

@glessard glessard deleted the rdar105651154-disable-debuginfo-test branch February 22, 2023 17:43
@adrian-prantl
Copy link
Contributor

Reverted in #63847.

@adrian-prantl
Copy link
Contributor

Assuming that this isn't the correct fix

Disabling a test is rarely the correct fix ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants